Restore unification of multi-page post content in Reader mode #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
commented
Apr 7, 2020
| @@ -342,8 +342,14 @@ private function build_post_comments_data() { | |||
| * Build post content. | |||
| */ | |||
| private function build_post_content() { | |||
| /** This filter is documented in wp-includes/post-template.php */ | |||
| $content = apply_filters( 'the_content', get_the_content( null, false, $this->post ) ); | |||
There was a problem hiding this comment.
Note that this did not need the post_password_required() check before because get_the_content() has that logic inside of it.
|
Workaround plugin which implements this while waiting for 1.5.3: https://gist.github.com/westonruter/559c7a9cbb9460d1099c3d5d9bfa5ad1 |
9 tasks
pierlon
approved these changes
Apr 8, 2020
schlessera
requested changes
Apr 8, 2020
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
schlessera
approved these changes
Apr 9, 2020
westonruter
added a commit
that referenced
this pull request
Apr 9, 2020
* Restore unification of multi-page post content in Reader mode * Combine comments Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com> * Fix Squiz.WhiteSpace.SuperfluousWhitespace.EndLine Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
westonruter
added a commit
that referenced
this pull request
Apr 10, 2020
…aching-reenable-button * 'develop' of github.com:ampproject/amp-wp: Restore unification of multi-page post content in Reader mode (#4547) Prevent styles from being removed when in Customizer preview with Standard mode (#4553) Omit Jetpack from being activated during PHPUnit test runs Use title case for Paired Browsing link in edit post screen (#4540) Ensure that validation query vars persist through redirects (#4544) Update dependency babel-jest to v25.2.6 (#4510) Update dependency css-loader to v3.5.0 (#4537) Update dependency autoprefixer to v9.7.6 (#4539) Add requirements to plugin file header (#4543) Force status code of validation responses to be 200 (#4533) Update optimizer test specs (#4527) Bump stable tag to 1.5.2 Cache response status and headers when fetching external stylesheets (#4509) Fix securing multi-line mustache templates (#4521) Add CSS monitoring time series to Site Health debugging info (#4519) Update hostname used for WordPress TV embeds to fix external HTTP requests (#4524) Mock Imgur embed tests Mock Facebook embed tests Standardize file and class names for embed handlers
westonruter
added a commit
that referenced
this pull request
Apr 15, 2020
* tag '1.5.3': Bump 1.5.3 Bump version to 1.5.3-RC1 Fix handling of Mustache templates (#4583) Stub request based on test scenario (#4588) Update tests after block-library/style.css changes in Gutenberg 7.9 (#4579) Restrict doing plugin upgrade routine when not in admin (#4538) Add new accessibility sanitizer (#4535) Fix unit tests (#4564) Add button into Site Health to reenable CSS transient caching (#4522) Restore unification of multi-page post content in Reader mode (#4547) Prevent styles from being removed when in Customizer preview with Standard mode (#4553) Omit Jetpack from being activated during PHPUnit test runs (#4474) Mock Facebook embed tests (#4474) Mock Imgur embed tests (#4474) Use title case for Paired Browsing link in edit post screen (#4540) Ensure that validation query vars persist through redirects (#4544) Add requirements to plugin file header (#4543) Force status code of validation responses to be 200 (#4533) Update optimizer test specs (#4527) Bump 1.5.3-alpha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally reported on a support forum topic:
The regression was introduced in #3781 via this change: https://github.com/ampproject/amp-wp/pull/3781/files#r405130526
The switch to
get_the_content()caused pagination to be introduced which was not present before, whenpost_contentwas directly passed intothe_contentfilters.Checklist